[PF-2262] Lift React v19 peer dep cap - #5070
Draft
azebich wants to merge 2 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: cc6fa65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
📖 Storybook Preview 🚀 Your Storybook preview is ready: View Storybook 📍 Preview URL: This preview is updated automatically when you push changes to this PR. |
Contributor
|
📖 Storybook Preview 🚀 Your Storybook preview is ready: View Storybook 📍 Preview URL: This preview is updated automatically when you push changes to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PF-2262
Description
Unblocks React 19 support across the library (objective O2). Plan of record and verified
current-state analysis: PF-2236 (spike).
MUI v4/v5 are fully removed from Picasso,
@base-ui/react@1.6.0already supports React 19, andcomponent source is clean of the patterns React 19 removed. What is left is peer-dependency and
config hygiene, a small ref-plumbing fix, third-party library upgrades, and — the critical path —
the React 19 validation harness, which does not exist yet. Nothing has been validated on React 19
so far, so the harness is what makes "React 19 validated" a real claim rather than an assumed one.
Workstreams in this PR:
A. Peer-dep cap sweep — drop the upper bound on every remaining package
(
react: ">=17.0.0 < 19.0.0"→">=17.0.0"), currently 88 of 91 workspace packages. Also dropthe
react-domcap, present on 6 packages (picasso,picasso-forms,picasso-query-builder,picasso-rich-text-editor,shared,base/Page). Applied via codemod; widening a peer range is aminor bump.
B. Types + TS prerequisite — in
pnpm-workspace.yaml, bump@types/react17→^19, add@types/react-dom(absent today), and move thereact/react-domoverrides to^19. The TSprerequisite is already met: the repo is on TypeScript
~5.5.0and@types/react@19needs ≥ 5.0.C. Ref / transition cluster — replace the element
.refreads (and their bare@ts-ignores) inFade.tsx:30, Slide.tsx:64 and ClickAwayListener.tsx:89.
nodeRefis already threaded through Fadeand Slide, so the remaining gap is Collapse.tsx:87, whose
<Transition>has nonodeRefandtherefore still reaches the removed
findDOMNodeunderreact-transition-group@4. Smoke-test the29
cloneElementsites.D. Third-party lib upgrades —
react-day-picker^8.10.0→ v9,react-querybuilder6.5.4→v7+,
recharts^2.12.3→ ≥ 2.13,react-transition-group(nodeRef, see §C). Validate orreplace
react-final-form@^6.5.9,react-router-dom@^5.3.4,react-helmet-async@2.0.3,react-input-mask@^3.0.0-alpha.2andreact-truncate@^2.4.0.E. Validation harness (critical path) — add the
test:react19script and areact19-validateCIjob: side-by-side React 19 install, stories rendered through RTL in
StrictMode, asserting nowarnings or errors. This replaces the placeholder that currently skips React 19 validation entirely.
F. Validate + release — harness green across the library, then ship the minor version bump.