[PF-2236] Unlock react-truncate react version support - #5066
Open
azebich wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: d8919fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
📖 Storybook Preview 🚀 Your Storybook preview is ready: View Storybook 📍 Preview URL: This preview is updated automatically when you push changes to this PR. |
azebich
changed the base branch from
master
to
feature/pf-2262-lift-the-react-19-peer-dep
July 28, 2026 12:24
azebich
force-pushed
the
pf-2236-react-truncate
branch
from
July 28, 2026 12:25
579e87c to
d8919fc
Compare
azebich
marked this pull request as ready for review
July 28, 2026 12:26
Contributor
|
📖 Storybook Preview 🚀 Your Storybook preview is ready: View Storybook 📍 Preview URL: This preview is updated automatically when you push changes to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PF-2236
Description
ShowMorewas the last component blocking React 19 support on its package: it depended onreact-truncate, which is unmaintained (last published 2018) and peer-locked toreact <= 16, so any React 19 consumer hits an unresolvable peer conflict.Changes:
react-truncatewith@re-dev/react-truncate, a maintained fork of exactlyreact-truncate@2.4.0(hooks + TypeScript rewrite, React 16–19 peers, zero runtime deps, ships its own types). TheTruncateAPI (lines,onTruncate) is identical — the component change is the import line only.0.6.0(no caret). The package has no npm provenance and a single maintainer, so the pin + lockfile integrity hash freeze the audited artifact. Security review done: OSV + npm advisories clean, no install scripts, no runtime deps, hand-audited dist (DOM/canvas measurement only — no network, storage, eval, or process access).@toptal/picasso-show-more(>=17.0.0 < 19.0.0→>=17.0.0), same as Backdrop/Accordion did when their blockers were removed.react-truncatedependency from@toptal/picassoand the now-unneeded@types/react-truncatefrom the root.Behavioral notes (verified):
\n→<br/>) content clamps correctly, expand/collapse round-trips to the exact full text.renderToString): full text in markup, same structure as before — no change.How to test
rowsrenders no togglepnpm test:unit -- packages/base/ShowMore— 8 tests greenScreenshots
Development checks
picasso-tailwind-mergerequires major update (check itsREADME.md)propsin component with documentationexamplesfor componentBreaking change
Alpha packages
Manually trigger the publish.yml workflow to publish alpha packages. Specify pull request number as a parameter (only digits, e.g.
123).PR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?