Skip to content

Add Hero component - #4968

Closed
denieler wants to merge 7 commits into
masterfrom
add-hero-component
Closed

Add Hero component#4968
denieler wants to merge 7 commits into
masterfrom
add-hero-component

Conversation

@denieler

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a new Hero component package (@toptal/picasso-hero) under packages/base/Hero
  • Minimal API: accepts children, supports className/style, and an as prop (section | header | div)
  • Follows existing Picasso component patterns (forwardRef, BaseProps, twMerge)

Test plan

  • pnpm build:package in packages/base/Hero
  • Import Hero from @toptal/picasso-hero in a consumer and verify render

🤖 Generated with Claude Code

@changeset-bot

changeset-bot Bot commented May 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 94dcdbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@denieler denieler self-assigned this May 20, 2026
@denieler
denieler force-pushed the add-hero-component branch 2 times, most recently from 301a0a3 to 27171be Compare May 20, 2026 11:45
denieler and others added 6 commits May 20, 2026 14:00
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@denieler
denieler force-pushed the add-hero-component branch from 27171be to a1ff8a3 Compare May 20, 2026 12:00
@toptal toptal deleted a comment from github-actions Bot May 20, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Picasso design patterns check failed

Rule Status
1 — Optimize defaults for the common case
2 — Reuse prop names across components
3 — Keep prop names short and simple
4 — Mirror native HTML prop names HeroImage exposes imageAlt instead of the native alt attribute
5 — Style overrides only via className or style
6 — Prefer children over content props
7 — Use rem for all sizes
8 — Align token names with the BASE design system
9 — Use variant for visual variations
10 — Extend BaseProps
11 — Use as to change the rendered element
12 — Use the shared size scale
13 — Use the shared color palette and shade scale
14 — No is prefix on boolean props isCompact should be compact
15 — Use compound components for multi-part components
16 — Use testIds for multi-part test selectors

@denieler denieler closed this May 20, 2026
@denieler
denieler deleted the add-hero-component branch May 20, 2026 12:07
@github-actions

Copy link
Copy Markdown
Contributor

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/4968/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant