fix: handle NULL car profile fields in /api/v1/cars - #511
Merged
Conversation
Fixes a corner case on fresh TeslaMate setups where car profile fields may still be NULL before the vehicle has come online. Update the /api/v1/cars endpoint to scan exterior_color, spoiler_type, and wheel_type with NullString so the endpoint stays resilient until TeslaMate populates the profile. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
tobiasehlert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a corner case on fresh TeslaMate setups where the car can still be offline/asleep and some profile fields in
carsremainNULL. In that window,/api/v1/carscould fail while scanning nullable text columns into Gostringfields.This change makes the endpoint resilient by scanning
exterior_color,spoiler_type, andwheel_typeasNullString, matching the existing handling fortrim_badging. That keeps the response working until TeslaMate has populated the full vehicle profile.This is intentionally scoped to the cars endpoint. Other endpoints may have their own nullable-field handling and were not changed here.
Fixes: #477