Add options to set battery capacity and range settings when new

[brunovale91]

This PR adds env variables to configure initial battery capacity and range. This will allow for proper battery health stats even when tesla mate does not have the full dataset since the purchase of the vehicle.

[LukStankovic]

Hi @brunovale91, thank you 🙏🏻 I completely missed that when I created that endpoint. Maybe it would be enough to pass only two variables like it is in Grafana?

[brunovale91]

Hi @brunovale91, thank you 🙏🏻 I completely missed that when I created that endpoint. Maybe it would be enough to pass only two variables like it is in Grafana?

Update to only use one variable for max range. Thank you for the API, great work!

[tobiasehlert]

Hmm.. well it would be working with Ken car, but what about those having multiple ones? Is it stored somewhere in some table from Grafana so we can access that?

[brunovale91]

Good point, I don’t think accessing grafana database is a good option since the structure can change with grafana updates. I would say the env variables can be improved to take a list of tuples with car_id:value or tesla mate can be improved to support this car configuration (probably best option but the one that’s more difficult to do).

[tobiasehlert]

I think the best way would be to have this added in TeslaMate. There are car-specific settings and we should probably be able to extend those with this parameters as well, which in its turn can be consumed by Grafana or us, instead of this being something stored in Grafana directly.

@brunovale91, do you want to make a feature request on the TeslaMate repository? :)

[brunovale91]

created a discussion for this: teslamate-org/teslamate#5087. Meanwhile going to change this PR to support a list of tupples.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tobiasehlert]

Hello @brunovale91,

What you think about adding such a feature in TeslaMate application instead and then include that added information in our endpoints later on? I saw your discussion (teslamate-org/teslamate#5087) and also another issue (teslamate-org/teslamate#5039) that are just about that issue.

Regards,
Tobias

[brunovale91]

@LukStankovic added a feature to HedgieMate which solves my specific case. I don't think it is ideal to have this on every client so I would still think it is better to have this feature implemented on the tesla mate application.

The solution on this PR also works but requires technical knowledge.