Skip to content

feat: add new years themed logo#1897

Open
tonymac129 wants to merge 3 commits into
tjcsl:devfrom
tonymac129:feature/new-years
Open

feat: add new years themed logo#1897
tonymac129 wants to merge 3 commits into
tjcsl:devfrom
tonymac129:feature/new-years

Conversation

@tonymac129
Copy link
Copy Markdown

@tonymac129 tonymac129 commented May 10, 2026

Proposed changes

  • Add new years fireworks Ion logo overlay
  • Add fireworks animation trigger button

Brief description of rationale

@tonymac129 tonymac129 requested a review from a team as a code owner May 10, 2026 04:27
@tonymac129 tonymac129 changed the title feat: add new years themed logo #1895 feat: add new years themed logo May 10, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented May 10, 2026 •
edited
Loading

Coverage Status

coverage: 79.245% (-0.02%) from 79.264% — tonymac129:feature/new-years into tjcsl:dev

aarushtools
aarushtools requested changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@aarushtools aarushtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tony,

Great start on this PR! I like the firework button addition. Right now the colorful fireworks on the logo are a little hard to see - maybe too dark? Can you try adjusting the contrast to make it look nicer. Thanks

Comment thread intranet/static/themes/new_years/new_years.js
}
});

$(".intranet-title-text").html(`Ion <img id="fireworks-btn" src="${path}new_years_party_popper.png" />`);
Copy link
Copy Markdown
Member

@aarushtools aarushtools May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment around line 50-55 of page_with_header.html saying that the ion new years html is edited through this file so people arent confused when looking at it

@tonymac129
Copy link
Copy Markdown
Author

tonymac129 commented May 13, 2026

Hi Aarush,
I increased the size, brightness, and contrast of the fireworks to improve visibility and added the comment to clarify how the logo is updated. Is there anything else I need to change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarushtools aarushtools aarushtools requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ion new years logo change

3 participants

@tonymac129 @coveralls @aarushtools