Skip to content

fix(memory): accept time_window_days alias in query_global #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graycyrus merged 2 commits into from
May 21, 2026
Merged

fix(memory): accept time_window_days alias in query_global #2350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcc40c9
fix(memory): accept time_window_days alias in QueryGlobalRequest
Liohtml May 20, 2026
5ac8a1c
Merge branch 'main' into fix/memory-tree-schema-mismatch
graycyrus May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions src/openhuman/memory/tree/retrieval/rpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ pub async fn query_source_rpc(
// ── query_global ──────────────────────────────────────────────────────

/// Request body for `memory_tree_query_global`.
///
/// The consolidated `memory_tree` tool schema advertises `time_window_days`
/// (consistent with `query_source` / `query_topic`), while the standalone
/// tool uses `window_days`. Accept both via serde alias so callers using
/// either field name succeed.
#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct QueryGlobalRequest {
#[serde(alias = "window_days")]
Expand Down Expand Up @@ -425,15 +430,19 @@ mod tests {
}

#[test]
fn query_global_request_accepts_legacy_window_days_alias() {
let req: QueryGlobalRequest = serde_json::from_value(serde_json::json!({
"window_days": 7
}))
.expect("legacy window_days alias should deserialize");

assert_eq!(req.time_window_days, 7);
fn query_global_request_accepts_both_field_names() {
// The consolidated memory_tree tool schema uses "time_window_days"
// while the standalone tool uses "window_days". Both must deserialize.
let from_alias: QueryGlobalRequest =
serde_json::from_value(serde_json::json!({"window_days": 7}))
.expect("legacy window_days alias should deserialize");
assert_eq!(from_alias.time_window_days, 7);

let from_primary: QueryGlobalRequest =
serde_json::from_value(serde_json::json!({"time_window_days": 30}))
.expect("primary time_window_days should deserialize");
assert_eq!(from_primary.time_window_days, 30);
}

// ── query_topic_rpc ───────────────────────────────────────────────

#[tokio::test]
Expand Down
Loading