fix(darwin): add DidUpdateNotificationState when enabling notifications - #433
Merged
deadprogram merged 3 commits intoApr 9, 2026
Merged
Conversation
Currently, enabling notifications does not check for errors.
Member
Author
|
@deadprogram @HattoriHanzo031 Applied new style code based on review. |
Member
|
Any further feedback on this @HattoriHanzo031 ? |
Contributor
No, LGTM |
HattoriHanzo031
approved these changes
Apr 9, 2026
Member
|
OK thanks for the fix @acouvreur and to @HattoriHanzo031 for review. Now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, enabling notifications does not check for errors.