[Windows] Fix write respond - #375
Merged
Merged
Conversation
maggch97
force-pushed
the
fix_windows_write_respond
branch
from
July 18, 2025 05:34
fbf8c2a to
087ff71
Compare
Member
|
Switched target branch to @jagobagascon any thoughts on this PR? |
jagobagascon
approved these changes
Jul 23, 2025
jagobagascon
left a comment
jagobagascon
left a comment
Member
There was a problem hiding this comment.
I tested it and can confirm it works. LGTM
Member
|
Thanks for the improvement @maggch97 and to @jagobagascon for review. Now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gattWriteRequest.Respond needs to be called if option is GattWriteOptionWriteWithResponse.