Address the complexity of main() - #47
Open
udf2457 wants to merge 1 commit into
Open
Conversation
An attempt to address the complexity of main() as originally reported by gocyclo and maintidx tests in golangci-lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a controversial disclosure, this PR is LLM assisted. I am not a vibecoder, but "clean up main()" seemed to me to be a focused enough task to try out, and given #43 has been open since March ...
This is what the LLM spat out and it seems like a reasonable attempt.
caseblocks.defer signer.Close()– the signer is closed automatically when runGetKey or runSign return, removing the manualsigner.Close()calls before everyos.Exit.main()is purely dispatch – parse → validate → run → exit. All business logic lives inrunGetKey,runSign, andrunVerify.