ctap: size response and HID buffers for 1200-byte CBOR messages - #104
Merged
Conversation
dehanj
approved these changes
Jul 10, 2026
Reduce the CTAP response buffer to 1200 bytes to match the advertised `maxMsgSize` value returned by GetInfo. Shrink the CTAPHID reassembly buffer accordingly and document the packet-size calculation for a 1200-byte CBOR payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce the CTAP response buffer to 1200 bytes to match the advertised
maxMsgSizevalue returned by GetInfo.Shrink the CTAPHID reassembly buffer accordingly and document the packet-size calculation for a 1200-byte CBOR payload.
Type of change
Please tick any that are relevant to this PR and remove any that aren't.
Submission checklist