Add versioning field to rk - #103
Open
dehanj wants to merge 2 commits into
Open
Conversation
Change `ctap_cbor_encode_credential_descriptor` to accept a `CredentialId *` instead of `struct Credential *`, since the function only accesses the credential ID. This removes unnecessary struct casts at the call sites in credential management and get assertion handlers.
- Move tag fields to the end of their structs so the authentication MAC covers the entire structure, including the new version byte. - Update RK_HMAC_SIZE to authenticate the full resident key. - Include the version in ctap_make_auth_tag().
jthornblad
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add versioning field to rk and credentialId.
Update so it is included in mac checks.
Type of change
Please tick any that are relevant to this PR and remove any that aren't.
Submission checklist