Add Modbus function 16 word order regression coverage#2134
Open
ilyar wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression coverage for Modbus RPC writes using function code
16with multi-register values.The tests verify that
wordOrderis preserved when values are encoded for device RPC writes:32intwithBIGword order writes[0x1234, 0x5678]32intwithLITTLEword order writes[0x5678, 0x1234]32floatwithBIGword order writes[0x4145, 0x70A4]32floatwithLITTLEword order writes[0x70A4, 0x4145]The routing-level test also uses the issue-shaped
setValueconfiguration withfunctionCode: 16,objectsCount: 2, andaddress: 4.This covers the behavior reported in #1275 without changing runtime logic. Current
masteralready produces the expected register order for this path, so the PR documents and protects the behavior with focused unit tests.Validation
.venv/bin/python -m pytest tests/unit/connectors/modbus/test_device_server_side_rpc.py- 11 passed.venv/bin/python -m pytest tests/unit/connectors/modbus- 34 passed