Conversation
Contributor
馃捇 Website PreviewThe latest changes are available as preview in: https://pr-2432.apollo-angular.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR updates Apollo Angular to be compatible with GraphQL 17 by widening supported peer dependency ranges and updating tooling/scripts to exercise GraphQL 17 in CI and local e2e workflows.
Changes:
- Expand
graphqlpeer dependency support to include v17 and update CI matrix to test GraphQL 17. - Update schematics defaults/tests and local e2e script to use GraphQL 17.
- Bump Apollo Client version in the demo app (and tighten peer range in the library).
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/pages/docs/recipes/multiple-clients.mdx | Minor formatting update to the multiple clients recipe snippet. |
| scripts/run-e2e-locally.sh | Run local e2e against GraphQL 17 and adjust Cypress schematic install invocation. |
| packages/demo/package.json | Bump demo app @apollo/client version. |
| packages/apollo-angular/test-utils/ObservableStream.ts | Formatting-only change to the ObservableEvent union type. |
| packages/apollo-angular/src/only-complete-data.ts | Add a TS suppression for onlyCompleteFragment typing. |
| packages/apollo-angular/schematics/tests/ng-add.spec.cts | Update schematic test input to GraphQL 17. |
| packages/apollo-angular/schematics/install/schema.json | Change default GraphQL version prompt to 17. |
| packages/apollo-angular/schematics/install/schema.cts | Update schema doc comment for default GraphQL version. |
| packages/apollo-angular/schematics/install/index.cts | Default schematics-installed GraphQL dependency to 17.x. |
| packages/apollo-angular/package.json | Update peer dependency ranges for GraphQL 17 and newer Apollo Client. |
| .github/workflows/main.yml | Add GraphQL 17 to the CI test matrix. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2431