feat: Add support for service registries - #440
Open
xlampa wants to merge 1 commit into
Open
Conversation
xlampa
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding ability to configure service registries in the Atlantis module.
Motivation and Context
#438
Main motivation is the issue above that was raised by my colleague.
TLDR; We want to reach out to Atlantis(and its API endpoints) from within the VPC and for the requests to stay internal to the VPC. We do see that the Atlantis module uses the upstream ECS module which has the
service_registriesvariable available here. We just want to expose this variable from the Atlantis module to allow us to configure service registries for our Atlantis instances.First time contributing to this project so if I missed anything, let me know. Hoping for your consideration on this PR. Thanks!
Breaking Changes
none
How Has This Been Tested?
Tested locally by deploying my forked repo's Atlantis module version. No issues encountered as expected.