fix: add approval gate to call-check-tflite-files job#3550
Open
q1uf3ng wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
q1uf3ng
force-pushed
the
fix/approval-gate-bypass
branch
from
842c33f to
ca6da64
Compare
Author
|
I have already signed the Google CLA. Please recheck. |
The call-check-tflite-files job in pr_test.yml is missing the needs: [gatekeeper, approval-gate] dependency that all other jobs have. This allows fork PRs to execute arbitrary code via the checked-out shell script without waiting for approval, bypassing the security gate. BUG=n/a
q1uf3ng
force-pushed
the
fix/approval-gate-bypass
branch
from
59dd4f1 to
7f42e57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call-check-tflite-filesinpr_test.ymlis missingneeds: [gatekeeper, approval-gate]. All other jobs (call-core,call-windows,call-cortex-m, etc.) have this dependency, butcall-check-tflite-filesruns immediately on any fork PR — checking out and executing fork-controlledcheck_tflite_files.shwithout waiting for approval.Fix
Add
needs: [gatekeeper, approval-gate]and theif: needs.gatekeeper.outputs.scope != 'none'condition, matching every other job in the workflow.BUG=n/a