ci: add missing approval-gate dependency to call-check-tflite-files#3542
Open
s2ongmo wants to merge 1 commit into
Open
ci: add missing approval-gate dependency to call-check-tflite-files#3542s2ongmo wants to merge 1 commit into
s2ongmo wants to merge 1 commit into
Conversation
The call-check-tflite-files job was missing the needs: [gatekeeper, approval-gate] dependency that all other test jobs in pr_test.yml have. This makes its gating consistent with call-core, call-windows, call-cortex-m, call-xtensa, call-hexagon, and call-riscv. The called workflow check_tflite_files.yml runs tensorflow/lite/micro/tools/ci_build/check_tflite_files.sh after checking out the PR head SHA, so it should be subject to the same approval gate as the other jobs that execute PR-controlled code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG=N/A
Description
The
call-check-tflite-filesjob in.github/workflows/pr_test.ymlis the only test job missing theneeds: [gatekeeper, approval-gate]dependency and the matchingif: needs.gatekeeper.outputs.scope != 'none'condition.All other test jobs (
call-core,call-windows,call-cortex-m,call-xtensa,call-hexagon,call-riscv) include this dependency, which was added when the gatekeeper/approval-gate system was introduced in #3426. This PR alignscall-check-tflite-fileswith the rest.Why this matters
The called workflow
check_tflite_files.ymlchecks out the PR head SHA and then runstensorflow/lite/micro/tools/ci_build/check_tflite_files.sh:Since
pr_test.ymlis triggered bypull_request_target, this script runs in a privileged context with access to repository secrets. Without the approval gate, it executes against any fork PR's HEAD before maintainer approval, which is the same risk the gate was added to address for the other jobs.You can see this happening in recent run history —
call-check-tflite-filescompletes during the window whenapproval-gateis stillwaiting, e.g.:Change
Two-line change, matches the pattern used by every other test job in the file.