Skip to content

Use ActivitySerializationContext when describing a Standalone Activity #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VegetarianOrc merged 3 commits into from
Jun 5, 2026
Merged

Use ActivitySerializationContext when describing a Standalone Activity #1583

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e9b241
Use ActivitySerializationContext when describing a Standalone Activity
VegetarianOrc Jun 4, 2026
ad437ee
remove unnecessary check
VegetarianOrc Jun 5, 2026
1bb5c27
Merge branch 'main' into amazzeo/activity-context-for-describe-activity
VegetarianOrc Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions temporalio/client/_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,9 +698,14 @@ async def describe_activity(
long_poll_token=resp.long_poll_token or None,
namespace=self._client.namespace,
data_converter=self._client.data_converter.with_context(
WorkflowSerializationContext(
ActivitySerializationContext(
namespace=self._client.namespace,
Copy link
Copy Markdown

@GregoryTravis GregoryTravis Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is _client.namespace guaranteed to always be the namespace that the activity started with? I'm not clear about whether the client and the workflow/activity always have the same namespace (but I assume they do).

Copy link
Copy Markdown
Contributor Author

@VegetarianOrc VegetarianOrc Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can't start/describe a workflow/activity unless you're auth'd against the namespace they are in. Except via Nexus of course 😎

workflow_id=input.activity_id, # Using activity_id as workflow_id for activities not started by a workflow
activity_id=resp.info.activity_id,
activity_task_queue=resp.info.task_queue,
activity_type=resp.info.activity_type.name,
workflow_id=None,
workflow_type=None,
is_local=False,
)
),
)
Expand Down
Loading