Route Ruby worker startup through an app registry#391
Draft
THardy98 wants to merge 1 commit into
Draft
Conversation
The Ruby worker now follows the app registry shape used by the other reorganized workers. The default worker app remains the kitchen sink worker, while startup goes through a small registry that can dispatch future app entrypoints. Constraint: Keep generated Ruby proto files in their existing location to avoid proto churn. Constraint: Preserve the existing Ruby worker image and sdkbuild entrypoint contracts. Rejected: Add lambda support in this change | the requested scope is app registry plumbing only. Confidence: high Scope-risk: moderate Tested: ruby -c workers/ruby/apps/registry.rb && ruby -c workers/ruby/apps/worker/app.rb && ruby -c workers/ruby/runner.rb Tested: mise exec -- go run ./cmd/dev test ruby Tested: mise exec -- go run ./cmd run-scenario-with-worker --scenario workflow_with_single_noop_activity --log-level debug --language ruby --app worker --embedded-server --iterations 1 Tested: mise exec -- go run ./cmd/dev lint-and-format ruby Tested: go test ./workers ./cmd ./cmd/cli ./cmd/clioptions Tested: git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ruby worker now follows the app registry shape used by the other reorganized workers. The default worker app remains the kitchen sink worker, while startup goes through a small registry that can dispatch future app entrypoints.