[release-v0.18.x] perf(cli): use exact match for describe/logs command#1335
Open
divyansh42 wants to merge 1 commit into
Open
[release-v0.18.x] perf(cli): use exact match for describe/logs command#1335divyansh42 wants to merge 1 commit into
divyansh42 wants to merge 1 commit into
Conversation
Add GetExactMatch() method to FilterOptions interface to distinguish
between exact match filtering (describe/logs) and substring matching
(list). This enables faster server-side filtering for operations that
query specific resources by name or UID.
Implementation details:
- Added GetExactMatch() to FilterOptions interface
- Updated BuildFilterString() to use exact equality (==) when
GetExactMatch() is true, otherwise uses contains() for substring
matching
- DescribeOptions and LogsOptions return true for exact matching
- ListOptions returns false to support partial name searches
- Updated command help text to document behavior
- Added test cases covering both list and describe filtering scenarios
When multiple resources match by name, describe/logs commands return the most recent one (ordered by create_time desc). Users can specify
--uid flag to target a specific resource when needed.
Signed-off-by: divyansh42 <diagrawa@redhat.com>
Assisted-by: Claude Sonnet 4.5 (via Claude Code)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Cherrypick for #1283
Add GetExactMatch() method to FilterOptions interface to distinguish between exact match filtering (describe/logs) and substring matching (list). This enables faster server-side filtering for operations that query specific resources by name or UID.
Implementation details:
When multiple resources match by name, describe/logs commands return the most recent one (ordered by create_time desc). Users can specify
--uid flag to target a specific resource when needed.
Signed-off-by: divyansh42 diagrawa@redhat.com
Assisted-by: Claude Sonnet 4.5 (via Claude Code)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes