Skip to content

Update treectrl.tcl - #9

Open
Meshparts wants to merge 1 commit into
tcltk-depot:mainfrom
Meshparts:patch-3
Open

Update treectrl.tcl#9
Meshparts wants to merge 1 commit into
tcltk-depot:mainfrom
Meshparts:patch-3

Conversation

@Meshparts

Copy link
Copy Markdown
Contributor

Further bug fixes ocuring in special situations (see new added comments)

Further bug fixes ocuring in special situations (see new added comments)
@apnadkarni

Copy link
Copy Markdown
Member

I will need more time to look at this. It seems to me that the correct selection fix (the shift case) would be to also track the window that had the selection and not just check whether the index exists in the new window because otherwise, if the new window did have a valid item (at the index in the old window), the selection would wrongly include that item from the current window. Am I wrong?

Also, has the indentation been changed? If possible, please try and keep it the same to make it easier to diff.

Thanks for taking the time to submit your contributions!

@Meshparts

Copy link
Copy Markdown
Contributor Author

I will need more time to look at this. It seems to me that the correct selection fix (the shift case) would be to also track the window that had the selection and not just check whether the index exists in the new window because otherwise, if the new window did have a valid item (at the index in the old window), the selection would wrongly include that item from the current window. Am I wrong?

Also, has the indentation been changed? If possible, please try and keep it the same to make it easier to diff.

Thanks for taking the time to submit your contributions!

Yes, you might very well be right.
This was a fix from me done quite a few years ago.
I was happy to avoid that error and had no other issues after that.
The indentation is different, because I hat the changed procedure in my main code, which uses different indentation.
Sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants