fix(analytics): add bottom margin so bar/line chart x-axis labels render (#969) - #977
Open
suantea wants to merge 4 commits into
Open
fix(analytics): add bottom margin so bar/line chart x-axis labels render (#969)#977suantea wants to merge 4 commits into
suantea wants to merge 4 commits into
Conversation
The server build writes server/tsconfig.tsbuildinfo into the repo root; git status was showing it as untracked noise.
…der (tashfeenahmed#969) BarChart and LineChart used margin bottom: 0, leaving no space for the x-axis tick labels. Hover tooltips showed the names, but the horizontal axis below was invisible. Bump to bottom: 12. Co-Authored-By: AtomCode (LongCat-2.0) <noreply@atomgit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\nBarChart and LineChart in AnalyticsPage used margin bottom: 0, leaving no space for x-axis tick labels. Hover tooltips showed names but the horizontal axis was invisible.\n\nBump to bottom: 12.\n\nCloses #969.