WIP: other key refactor attempt - #316
Draft
danderson wants to merge 1 commit into
Draft
Conversation
Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: I5bf5b07370c2bf3e8d09eb4f5d3bdcbe6a6a6964
danderson
force-pushed
the
push-uokuozswsznx
branch
from
July 29, 2026 21:20
ade80f7 to
130184e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #306, following @npry's proposal.
Haven't fixed up the callers yet, which have a few errors because I tried to shrink the number of conversions we offer to the subset that encouragages good APIs (in particular avoiding overuse of copy/clone in favor of passing by ref). I'd like thoughts on the shape of the API before I go through the slog of fixing everything else up.