fix(extension): replace broken wasm-pack installer URL with cargo install#86
Merged
jserv merged 1 commit intosysprog21:mainfrom May 8, 2026
Merged
Conversation
…tall The rustwasm.github.io/wasm-pack/installer/ URL returns 404. The alternative wasm-bindgen.github.io URL resolves but its shell installer fails with "ORIG_ARGS[@]: unbound variable". Since cargo is already required to build this project, direct users to "cargo install wasm-pack" instead — consistent with the extension README. Fixes: sysprog21#85 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
Thank @JackKuo-tw for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
extension/build-wasm.shpoints users to a broken URL whenwasm-packis not found:That URL returns 404. The alternative
https://wasm-bindgen.github.io/wasm-pack/installer/resolves but its shell installer script is broken:Fix
Since Rust (and therefore
cargo) is already a prerequisite for building this project,cargo install wasm-packis the most reliable installation method and requires no extra tooling. The extension README already uses this exact command.Change the error message to:
Closes #85
Summary by cubic
Replaced the broken
wasm-packinstaller URL inextension/build-wasm.shwith a directcargoinstall command to give a reliable setup path and match the README. Prevents build failures whenwasm-packis missing.wasm-pack, print: "wasm-pack is required. Install it with: cargo install wasm-pack"Written for commit e905b63. Summary will update on new commits.