Conversation
The kernel and rootfs archive hashes plus the input fingerprint were duplicated in mk/external.mk and required manual updating on every republish; missing the update made 'make check' fail at sha1sum -c. Move all three to a prebuilt.sha1 manifest published alongside the archives, so consumers (mk/external.mk, .github/workflows/main.yml) read whatever the publisher recorded. The manifest fetch is FORCE-rebuilt every invocation but cmp-deduped so downstream targets only invalidate when content actually changed. A failed fetch falls back to the cached manifest when one exists, and only aborts when no cache is available. Drift detection moves from a parse-time $(warning) to a runtime .PHONY: prebuilt-check target so it can read the inputs hash from the just-refreshed manifest. .ci/publish-prebuilt.sh writes a third line under the virtual name 'inputs' to expose that value. The publisher workflow's paths filter gains .ci/publish-prebuilt.sh so this change auto-republishes the manifest in the new format on merge. Close #136
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel and rootfs archive hashes plus the input fingerprint were duplicated in mk/external.mk and required manual updating on every republish; missing the update made 'make check' fail at sha1sum -c. Move all three to a prebuilt.sha1 manifest published alongside the archives, so consumers (mk/external.mk, .github/workflows/main.yml) read whatever the publisher recorded.
The manifest fetch is FORCE-rebuilt every invocation but cmp-deduped so downstream targets only invalidate when content actually changed. A failed fetch falls back to the cached manifest when one exists, and only aborts when no cache is available.
Drift detection moves from a parse-time $(warning) to a runtime .PHONY: prebuilt-check target so it can read the inputs hash from the just-refreshed manifest. .ci/publish-prebuilt.sh writes a third line under the virtual name 'inputs' to expose that value. The publisher workflow's paths filter gains .ci/publish-prebuilt.sh so this change auto-republishes the manifest in the new format on merge.
Close #136