fix(agent): support memdump and network_topology in secure light mode#2648
Open
juan-rodriguez-gracia wants to merge 1 commit into
Open
Conversation
Secure Light now supports `memdump` and `network_topology`; both were unavailable when Secure Light first shipped but have been added over time. The agent template still force-disabled them in `secure_light` mode, which prevented features that rely on memdump (such as policy-triggered captures) from working. Stop force-disabling `memdump` and `network_topology` for `secure_light`. They now follow their normal defaults and can still be controlled explicitly via `sysdig.settings`. Update the secure_light unit-test assertions and bump the chart version. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Hi @juan-rodriguez-gracia. Thanks for your PR. After inspecting your changes someone with write access to this repo needs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secure Light mode now supports
memdumpandnetwork_topology. Both features were unavailable when Secure Light first shipped but have been added over time. The agent template still force-disabled them forsecure_light, which prevented features that rely on memdump (such as policy-triggered captures) from working in this mode.This stops force-disabling
memdumpandnetwork_topologyinsecure_lightmode. They now follow their normal defaults and can still be set explicitly viasysdig.settings(the existing memdump override behavior is unchanged).The
secure_lighthelm-unittest assertions were updated to match the new behavior, and the agent chart version was bumped. Allcharts/agentunit tests pass (342/342).