[Concurrency] Re-apply typed throws and nonisolated(nonsending adoption in Task creation APIs#87103
Merged
Conversation
…tlang#84802)" This reverts commit 4f0b627.
ktoso
approved these changes
Feb 10, 2026
| @@ -167,6 +167,26 @@ extension Task { | |||
| /// | |||
| /// - Returns: The task's result. | |||
| public var value: Success { | |||
Contributor
There was a problem hiding this comment.
The actual culprit™, thanks for working through this Pavel, lgtm!
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
I have verified locally that swift-testing test-suite is now passing with new and old stdlib runtime without issues. |
xedin
force-pushed
the
rdar-168273419
branch
from
361a60f to
2d1f298
Compare
Contributor
Author
|
@swift-ci please clean test |
The original getter, unlike `Task.init`, wasn't emitted into client which means that the original property needs to be preserved for backward compatibility and new one needs to be `@_alwaysEmitIntoClient` with the new name. Resolves: rdar://168273419
xedin
force-pushed
the
rdar-168273419
branch
from
2d1f298 to
1fda405
Compare
Contributor
Author
|
@swift-ci please clean test |
ktoso
reviewed
Feb 11, 2026
| /// - Returns: A reference to the task. | ||
| % end # IS_DEPRECATED | ||
| ${"\n ".join(adjust_availability(ALL_AVAILABILITY))} | ||
| % if not IS_THROWING: |
Contributor
There was a problem hiding this comment.
This changes errors to not be silently ignored anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-applies #84802 and fixes a problem
with
Task.valueABI that the original PR created.The original getter of
Task.value, unlikeTask.init, wasn't emitted into clientwhich means that the original property needs to be preserved for
backward compatibility and new one needs to be
@_alwaysEmitIntoClientwith the new name.
Resolves: rdar://168273419