Skip to content

fix: avoid type errors with Cloudflare adapter #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teemingc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: avoid type errors with Cloudflare adapter #1098

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f0b597
Update sveltekit-adapter.ts
teemingc May 20, 2026
07ea835
Apply suggestion from @teemingc
teemingc May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/sv/src/addons/sveltekit-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,11 @@ export default defineAddon({
);

if (adapter.package === '@sveltejs/adapter-cloudflare') {
sv.devDependency('wrangler', '^4.81.0');
// we can use a newer version after migrating to SvelteKit 3
// wrangler@4.26.1 causes type errors when generating types because it includes
// the build output file which isn't type-safe
// see https://github.com/cloudflare/workers-sdk/pull/9897
sv.devDependency('wrangler', '4.26.0');

if (packageManager === 'pnpm') {
sv.file(file.findUp('pnpm-workspace.yaml'), pnpm.allowBuilds('workerd', 'sharp'));
Expand Down Expand Up @@ -187,8 +191,10 @@ export default defineAddon({
file.package,
transforms.json(({ data, json }) => {
json.packageScriptsUpsert(data, 'gen', 'wrangler types');
json.packageScriptsUpsert(data, 'check', 'wrangler types --check', { mode: 'prepend' });
json.packageScriptsUpsert(data, 'build', 'wrangler types --check', { mode: 'prepend' });
json.packageScriptsUpsert(data, 'check', 'pnpm gen', { mode: 'prepend' });
Comment thread
teemingc marked this conversation as resolved.
// use `wrangler types --check` when we move to SvelteKit 3 and a newer wrangler version
// json.packageScriptsUpsert(data, 'check', 'wrangler types --check', { mode: 'prepend' });
// json.packageScriptsUpsert(data, 'build', 'wrangler types --check', { mode: 'prepend' });
})
);

Expand Down
Loading