Skip to content

feat(sv): use eslint's includeIgnoreFile #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glypse wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(sv): use eslint's includeIgnoreFile #1094

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ec00fe
feat(sv): use `eslint`'s `includeIgnoreFile` instead of `@esllint/com…
glypse May 16, 2026
fbbff3a
Add feature changeset
glypse May 16, 2026
1793a8c
Update .changeset/few-mugs-stare.md
glypse May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-mugs-stare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'sv': minor
---

Replace `includeIgnoreFile` from `@eslint/compat` to `eslint/config`
Comment thread
glypse marked this conversation as resolved.
Outdated
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@types/node": "^20.19.30",
"@typescript/native-preview": "7.0.0-dev.20251212.1",
"@vitest/ui": "4.1.1",
"eslint": "^10.2.0",
"eslint": "^10.4.0",
"eslint-plugin-svelte": "^3.17.0",
"magic-string": "^0.30.21",
"prettier": "^3.8.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/sv/src/addons/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import process from 'node:process';
// This is in common because the eslint addon installs this version,
// and the prettier addon uses this to check if the installed major version of
// eslint is supported by `addEslintConfigPrettier(...)`.
export const ESLINT_VERSION = /* update-deps: eslint */ '^10.2.0';
export const ESLINT_VERSION = /* update-deps: eslint */ '^10.4.0';

export const addEslintConfigPrettier = transforms.script(({ ast, js }) => {
// if a default import for `eslint-plugin-svelte` already exists, then we'll use their specifier's name instead
Expand Down
3 changes: 1 addition & 2 deletions packages/sv/src/addons/eslint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export default defineAddon({
const prettierInstalled = Boolean(dependencyVersion('prettier'));

sv.devDependency('eslint', ESLINT_VERSION);
sv.devDependency('@eslint/compat', '^2.0.4');
sv.devDependency('eslint-plugin-svelte', '^3.17.0');
sv.devDependency('globals', '^17.4.0');
sv.devDependency('@eslint/js', '^10.0.1');
Expand Down Expand Up @@ -148,7 +147,7 @@ export default defineAddon({
js.imports.addDefault(ast, { from: 'eslint-plugin-svelte', as: 'svelte' });
js.imports.addDefault(ast, { from: '@eslint/js', as: 'js' });
js.imports.addNamed(ast, {
from: '@eslint/compat',
from: 'eslint/config',
imports: ['includeIgnoreFile']
});
js.imports.addDefault(ast, { from: 'node:path', as: 'path' });
Expand Down
3 changes: 1 addition & 2 deletions packages/sv/src/cli/tests/snapshots/create-with-all-addons/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import prettier from 'eslint-config-prettier';
import path from 'node:path';
import { includeIgnoreFile } from '@eslint/compat';
import js from '@eslint/js';
import svelte from 'eslint-plugin-svelte';
import { defineConfig } from 'eslint/config';
import { defineConfig, includeIgnoreFile } from 'eslint/config';
import globals from 'globals';
import ts from 'typescript-eslint';
import svelteConfig from './svelte.config.js';
Expand Down
3 changes: 1 addition & 2 deletions packages/sv/src/cli/tests/snapshots/create-with-all-addons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
},
"devDependencies": {
"@better-auth/cli": "~1.4.21",
"@eslint/compat": "^2.0.4",
"@eslint/js": "^10.0.1",
"@inlang/paraglide-js": "^2.15.2",
"@libsql/client": "^0.17.2",
Expand All @@ -38,7 +37,7 @@
"better-auth": "~1.4.21",
"drizzle-kit": "^0.31.10",
"drizzle-orm": "^0.45.2",
"eslint": "^10.2.0",
"eslint": "^10.4.0",
"eslint-config-prettier": "^10.1.8",
"eslint-plugin-svelte": "^3.17.0",
"globals": "^17.4.0",
Expand Down
Loading
Loading