feat: persist runner execution logs and serve history via API #5381
feat: persist runner execution logs and serve history via API #53810vertake wants to merge 2 commits into
Conversation
|
👋 Commands for maintainers:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fee5f5c. Configure here.
| Environment: environment, | ||
| ExecutionMode: mode, | ||
| DockerImage: resolvedRunBashDockerImageRef(spec), | ||
| TimeoutSeconds: spec.ExecutionTimeoutSeconds, |
There was a problem hiding this comment.
Bash runner drops upstream payload
High Severity
Run Bash now creates broker tasks with only commands and no message_chain, while JS/Python runners still send upstream data that way. Bash scripts and docs rely on SUPERPLANE_PAYLOAD_FILE being populated from that chain, so workflows reading upstream context can fail or see empty payload after this change.
Reviewed by Cursor Bugbot for commit fee5f5c. Configure here.
Docs Impact ReviewThis PR adds a new public API endpoint for retrieving persisted runner execution logs, which is a meaningful new capability not mentioned anywhere in the current docs. Suggested docs updates:
Why: The PR introduces Maintainers: Reply with Posted automatically by warp-gateway · commit 0fac001 |
fee5f5c to
a9c2142
Compare
|
/docs-reject |
Signed-off-by: Milos Jovanovic <milosjovanovic519@gmail.com>
a9c2142 to
92ea4b3
Compare
| @@ -0,0 +1,24 @@ | |||
| CREATE TABLE IF NOT EXISTS workflow_node_execution_logs ( | |||
There was a problem hiding this comment.
Why are we storing these in the database? Shouldn't we use S3?
The /api/v1/runner-logs endpoint was registered inside RegisterGRPCGateway, which is only called when START_GRPC_GATEWAY=yes. This meant the route was never active in deployments without gRPC gateway. Move the route registration to InitRouter so it's always available. The endpoint uses its own Bearer-token auth (TASK_BROKER_AUTH_TOKEN) and does not require org context or gRPC. Signed-off-by: Leo <leo@superplane.com>


No description provided.