fix: resolve matchList per item in list-mode memory components#5357
Open
andrecalil wants to merge 5 commits into
Open
fix: resolve matchList per item in list-mode memory components#5357andrecalil wants to merge 5 commits into
andrecalil wants to merge 5 commits into
Conversation
In list-mode upsertMemory and updateMemory, the matchList was built once
from raw pairs and reused across iterations, so expressions like
item.uuid never resolved to the current element. As a result every
iteration tried to match (or upsert against) the same global row.
Resolve matchList per item with the iteration variable in scope (same
rules as valueList), so each element matches its own row. To keep a
global match across iterations, users can still write a {{ ... }}
template (resolved before iteration starts). Docs and configuration
descriptions are updated accordingly, and per-item match values are
exposed in the emitted event under data.items[*].matches.
Also clarify the dashboard markdown docs that mapped lists now render
as JSON unless joined, since the renderer change lives in main.
Signed-off-by: André Calil <andre@calil.com.br>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
👋 Commands for maintainers:
|
superplane-policy-bot
Bot
requested review from
forestileao,
lucaspin and
shiroyasha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In list-mode upsertMemory and updateMemory, the matchList was built once from raw pairs and reused across iterations, so expressions like item.uuid never resolved to the current element. As a result every iteration tried to match (or upsert against) the same global row.
Resolve matchList per item with the iteration variable in scope (same rules as valueList), so each element matches its own row. To keep a global match across iterations, users can still write a {{ ... }} template (resolved before iteration starts). Docs and configuration descriptions are updated accordingly, and per-item match values are exposed in the emitted event under data.items[*].matches.
Also clarify the dashboard markdown docs that mapped lists now render as JSON unless joined, since the renderer change lives in main.
Resolves #5356