Skip to content

Emit 'exit' immediately on EXIT byte (~38x exec speedup) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhgaylor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Emit 'exit' immediately on EXIT byte (~38x exec speedup) #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/websocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,14 @@ export class WSCommand extends EventEmitter {
break;
case StreamID.Exit:
this.exitCode = payload.length > 0 ? payload[0] : 0;
// Emit 'exit' immediately. The server holds the WS open ~5s after
// sending EXIT before initiating its own close handshake, so
// waiting for handleClose to fire 'exit' adds a fixed ~5s tax to
// every exec. Fire-and-forget close — matches the Elixir SDK.
if (!this.done) {
this.done = true;
this.emit('exit', this.exitCode);
}
this.close();
break;
}
Expand Down