Skip to content

Check version before running migration #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
somtochiama wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −1
Open

Check version before running migration #483

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e464a23
run migration if crsqlite version is less than 0.17
somtochiama Jun 2, 2026
7a7c771
remove stray import
somtochiama Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions crates/corro-types/src/agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use camino::Utf8PathBuf;
use metrics::{gauge, histogram};
use parking_lot::RwLock;
use rangemap::RangeInclusiveSet;
use rusqlite::{Connection, OpenFlags, Transaction};
use rusqlite::{Connection, OpenFlags, OptionalExtension, Transaction};
use serde::{Deserialize, Serialize};
use serde_json::json;
use sqlite_pool::SqliteConn;
Expand All @@ -27,7 +27,7 @@ use tokio::{
time::timeout,
};
use tokio_util::sync::{CancellationToken, DropGuard};
use tracing::{debug, error, warn};
use tracing::{debug, error, info, warn};
use tripwire::Tripwire;

use crate::{
Expand Down Expand Up @@ -408,6 +408,18 @@ fn crsqlite_v0_17_migration(
let ts = Timestamp::from(clock.new_timestamp()).as_u64().to_string();

move |tx: &Transaction| -> rusqlite::Result<()> {
let version: Option<i64> = tx
.query_row(
"SELECT value FROM crsql_master WHERE key = 'version'",
[],
|row| row.get(0),
)
.optional()?;
// we only want to run this migration if the version is less than 17_00_00
if version.is_none_or(|v| v >= 17_00_00) {
return Ok(());
}

let tables: Vec<String> = tx.prepare("SELECT tbl_name FROM sqlite_master WHERE type='table' AND tbl_name LIKE '%__crsql_clock'")?.query_map([], |row| row.get(0))?.collect::<rusqlite::Result<Vec<_>>>()?;

for table in tables {
Expand Down
Loading