Add internationalization context - #3813
Open
connor-baer wants to merge 13 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: b5e8935 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3813 +/- ##
==========================================
- Coverage 93.60% 93.56% -0.05%
==========================================
Files 209 210 +1
Lines 4628 4628
Branches 1804 1806 +2
==========================================
- Hits 4332 4330 -2
- Misses 267 269 +2
Partials 29 29
🚀 New features to boost your workflow:
|
Contributor
|
Size Change: +577 B (+0.07%) Total Size: 851 kB 📦 View Changed
ℹ️ View Unchanged
|
This reverts commit ee64262.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Circuit UI supports localization and locale-aware formatting for any language and region. Currently, the locale defaults to the browser locale and can only be overridden on the component level which is tedious for developers.
Approach and changes
I18nProvidercomponent that enables developers to set the locale for all design system components globally. Thelocaleprop determines the language of built-in translations strings. TheformattingLocaleprop determines how to format date, time, currency, and other numeric values and falls back to thelocaleprop.formattingLocaleprop and deprecated thelocaleprop on various components.useI18n→useTranslationsanduseLocale→useI18n.Definition of done