fix: issue with autocomplete input blur - #3690
Open
nicosommi wants to merge 4 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: a26a609 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nicosommi
changed the title
Contributor
|
Size Change: +97 B (+0.01%) Total Size: 850 kB 📦 View Changed
ℹ️ View Unchanged
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3690 +/- ##
=======================================
Coverage 93.51% 93.52%
=======================================
Files 208 208
Lines 4614 4621 +7
Branches 1803 1805 +2
=======================================
+ Hits 4315 4322 +7
Misses 270 270
Partials 29 29
🚀 New features to boost your workflow:
|
sirineJ
reviewed
Jun 11, 2026
|
|
||
| if (!movingInside) { | ||
| syncSearchOnDismiss(); | ||
| } |
Contributor
There was a problem hiding this comment.
Thank you for catching this issue, @nicosommi 👏
I believe there could be a simpler way to address it. If we fire a change event here (like we do in the onComboboxClear callback) I believe we could achieve the same thing:
Suggested change
| } | |
| } | |
| if (!value && searchText !== '') { | |
| changeInputValue(comboboxRef.current, ''); | |
| } |
Member
Author
There was a problem hiding this comment.
Good call on reusing changeInputValue for the clear-to-empty path — adopted that in syncSearchOnDismiss for !value && searchText !== '' (and multi-select filter reset), same as onComboboxClear.
Kept setSearchText for the preselected-value restore path because firing a change to the label would debounce onSearch(label) and leave client-filtered options stale again. Still emit onSearch('') explicitly so consumers get the full list on reopen.
movingInside + syncSearchOnDismiss on Escape/modal close remain for Tab-close and immersive dismiss.
sirineJ
reviewed
Jul 8, 2026
sirineJ
reviewed
Jul 29, 2026
| } | ||
| }, [isOpen, update, options.length, value]); | ||
|
|
||
| const handleClickOutside = useCallback(() => { |
Contributor
There was a problem hiding this comment.
removed in favor of addEventListener('focusout')
sirineJ
force-pushed
the
fix/autocomplete-input-contract
branch
from
July 30, 2026 07:28
3e4d728 to
641b116
Compare
sirineJ
force-pushed
the
fix/autocomplete-input-contract
branch
from
July 30, 2026 08:09
641b116 to
a26a609
Compare
connor-baer
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No ticket yet
How to reproduce the issue
Purpose
Fix the issue mentioned above, spotted here
Approach and changes
Definition of done