Skip to content

Feat/hoge - #3

Open
sugawani wants to merge 3 commits into
masterfrom
feat/hoge
Open

Feat/hoge#3
sugawani wants to merge 3 commits into
masterfrom
feat/hoge

Conversation

@sugawani

Copy link
Copy Markdown
Owner

No description provided.

@what-the-diff

what-the-diff Bot commented Dec 26, 2022

Copy link
Copy Markdown
  • Changed the title of index.tsx
  • Added a function to sum two numbers in index.tsx
  • Increased padding from 6rem to 8rem in Home module css file

Comment thread my-app/pages/index.tsx
Comment on lines +8 to +10
const sum = function(a:number, b:number):number {
return a+b;
}

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wtd

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const sum = function(a:number, b:number):number {
return a+b;
}
const sum = function(a:number, b:number):number {
return a+b;
}

Comment thread my-app/pages/index.tsx
Comment on lines +8 to +10
const sum = function(a:number, b:number):number {
return a+b;
}

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wtd use an arrow function

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const sum = function(a:number, b:number):number {
return a+b;
}
const sum = (a:number, b:number):number => a+b;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant