Skip to content

ci: verify generated ANTLR parsers#1124

Merged
nielspardon merged 1 commit into
substrait-io:mainfrom
bvolpato:bvolpato/ci-check-antlr-generated-parsers
Jul 15, 2026
Merged

ci: verify generated ANTLR parsers#1124
nielspardon merged 1 commit into
substrait-io:mainfrom
bvolpato:bvolpato/ci-check-antlr-generated-parsers

Conversation

@bvolpato

@bvolpato bvolpato commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

Regenerate committed ANTLR parsers during pull request CI and fail when generated output differs. This ensures grammar and ANTLR-version changes include matching generated Python files.

Changes

  • add a dedicated Check ANTLR Parsers job
  • declare generated parser files as Pixi task outputs so output drift invalidates task caching

Testing

  • pixi run generate-antlr
  • git diff --exit-code -- tests/coverage/antlr_parser tests/type/antlr_parser
  • pixi run lint
  • pixi run test (137 passed)
  • temporarily changed grammar and confirmed generated-diff check exits 1
  • temporarily changed generated output and confirmed Pixi regenerates it

Closes #770.


This change is Reviewable

Regenerate committed parsers during PR checks and fail when output drifts. Track parser outputs so Pixi reruns generation after output changes.
@bvolpato bvolpato marked this pull request as ready for review July 15, 2026 03:29

@nielspardon nielspardon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielspardon nielspardon merged commit 2cb2755 into substrait-io:main Jul 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] enforce ANTLR version used to generate parsers

2 participants