Dive roles: custom roles and the diver's own role on a dive#561
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #551
Closes #547
Summary
Adds a
dive_rolesreference table (schema v103) mirroring the dive-types pattern: nine seeded built-in roles (the six legacy roles plus Rear Guard, Support Diver, Safety Diver) and user-defined custom roles with UUID ids. The per-dive buddy role now resolves against this table instead of the fixedBuddyRoleenum, and dives gain a nullablediver_rolecolumn recording the active diver's own role.#551 - custom/extensible roles
#547 - my own role
diverRoleIdfirst-non-null (follows the Merging dives deletes GPS location data #542 scalar-adopt pattern)Sync / backup
dive_rolesis an HLC-synced entity: custom rows only (built-ins are seeded locally and re-asserted inbeforeOpen), tombstoned deletions, adopt-wipe preserves built-insdive_buddies.role/dives.diver_rolereferences resolve after restoreMigration
dive_roles, adddives.diver_role; idempotent withbeforeOpenbackstop; existingdive_buddies.rolestrings match the built-in slugs so no data migration is neededTesting
flutter analyzecleanRemaining manual verification