feat: support # comments in allowed-endpoints input#668
Open
vincentayorinde wants to merge 1 commit into
Open
Conversation
Fixes step-security#199 Users can now add comment lines starting with # in the allowed-endpoints input to document why each endpoint is needed. Example: allowed-endpoints: | api.github.com:443 # needed for npm install registry.npmjs.org:443
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #199
What
Users can now add
#comment lines in theallowed-endpointsinput to document why each endpoint is needed.Example
Changes
src/utils.ts— addedstripEndpointComments()helper that filters#comment and blank linessrc/setup.ts— wrapsallowed-endpointsinput withstripEndpointComments()src/utils.test.ts— 4 new tests covering comments, blank lines, empty input, all-comment input