Skip to content

historyarchive: bound the cache writer and cache only completed downloads #5975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karthikiyer56 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

historyarchive: bound the cache writer and cache only completed downloads #5975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
09c0baa
historyarchive: bound the cache writer's lifetime and size
karthikiyer56 Aug 10, 2026
44591a3
historyarchive: share one cache across an archive pool
karthikiyer56 Aug 10, 2026
8ad42f2
historyarchive: return scan and mirror worker errors instead of panic…
karthikiyer56 Aug 10, 2026
1eeca8b
historyarchive: cache only completed downloads, stream past cache limits
karthikiyer56 Aug 10, 2026
9731dcd
historyarchive: don't classify a bucket as missing when its check fails
karthikiyer56 Aug 10, 2026
035fdbe
historyarchive: fix err shadowing in cache tests flagged by vet shadow
karthikiyer56 Aug 10, 2026
57bd666
historyarchive: rename pth to path and cut comment verbosity
karthikiyer56 Aug 10, 2026
be518fd
changelog: entries for the historyarchive cache and scan fixes
karthikiyer56 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,18 @@ Official project releases may be found here: https://github.com/stellar/go-stell

### New Features
* protocols/rpc: Add `LatestLedgerCloseTime` and `OldestLedgerCloseTime` to `GetHealthResponse`, exposing the latest and oldest ledgers' close times (unix seconds) on the `getHealth` response ([#5958](https://github.com/stellar/go-stellar-sdk/pull/5958))
* historyarchive: Added `ArchiveOptions.MaxCacheFileSize`, capping the size of any single file written to the on-disk cache (default 8 GiB); larger files are served in full, just not cached ([#5975](https://github.com/stellar/go-stellar-sdk/pull/5975))

### Breaking Changes
* xdr: `Asset.LessThan` now orders assets the way the protocol does — by the raw 32-byte issuer key — instead of by base32 strkey text, and `xdr.NewPoolId` requires strictly `a < b`, rejecting reversed and identical pairs ([#5974](https://github.com/stellar/go-stellar-sdk/pull/5974))
* txnbuild: liquidity pool operations reject asset pairs that are not strictly ordered; see the [txnbuild changelog](./txnbuild/CHANGELOG.md) ([#5974](https://github.com/stellar/go-stellar-sdk/pull/5974))

### Bug Fixes
* processors/token_transfer: trustline revocation now compares liquidity pool assets by value instead of pointer identity, fixing wrong-leg selection when burning pool shares ([#5974](https://github.com/stellar/go-stellar-sdk/pull/5974))
* historyarchive: closing an archive stream now stops its underlying download — an abandoned download no longer keeps writing to the on-disk cache without bound — and the cache's 10 GiB budget is enforced while downloads run, not only between them ([#5975](https://github.com/stellar/go-stellar-sdk/pull/5975))
* historyarchive: only fully downloaded files are cached — a download that fails mid-copy can no longer leave a truncated cache entry that readers consume as a complete file ([#5975](https://github.com/stellar/go-stellar-sdk/pull/5975))
* historyarchive: an archive pool shares one cache across its members instead of each building its own over the same directory, which multiplied the size budget and hid each member's files from the others' eviction ([#5975](https://github.com/stellar/go-stellar-sdk/pull/5975))
* historyarchive: `Scan` and `Mirror` workers return errors instead of panicking on a failed request ([#5975](https://github.com/stellar/go-stellar-sdk/pull/5975))

## [0.7.0]

Expand Down
Loading
Loading