Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
commented
May 9, 2026
…/is-*-property` benchmarks Propagates fix from 6f01b40 ("fix: resolve JavaScript lint errors") to the remaining `assert/is-*-property` benchmarks: replaces `arr = new Array( 100 );` with `arr = zeros( 100, 'generic' );` and adds the corresponding `@stdlib/array/zeros` require, eliminating the `stdlib/no-new-array` lint warning. The accompanying inline `// eslint-disable-line stdlib/no-new-array` directive in `is-readable-property-in` is removed along with the violation. Applies to 19 benchmark files under `assert/is-*-property/`. https://claude.ai/code/session_019qz8kssWMLenCUTsgngDXj
aa226f2 to
ae469a0
Compare
blas, lapack, math, and assertnew Array(100) with zeros(100, 'generic') in assert/is-*-property benchmarks
new Array(100) with zeros(100, 'generic') in assert/is-*-property benchmarksnew Array(100) with zeros(100, 'generic') in assert/is-*-property benchmarks
kgryte
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-05-08 17:03 PDT and 2026-05-09 02:24 PDT to sibling packages with the same defect.6f01b40— replacenew Array(100)withzeros(100, 'generic')inassert/is-*-propertybenchmarksMirrors
6f01b40across 19 benchmark files: replacesnew Array( 100 )withzeros( 100, 'generic' )and adds the corresponding@stdlib/array/zerosrequire after theisBooleanimport, resolvingstdlib/no-new-arrayviolations. Thearrvariable serves only as a property-inspection target, so zero-initialization is semantically equivalent to uninitialized. Foris-readable-property-in, the inline// eslint-disable-line stdlib/no-new-arraysuppression directive is also removed alongside the violation it masked.lib/node_modules/@stdlib/assert/is-accessor-propertylib/node_modules/@stdlib/assert/is-accessor-property-inlib/node_modules/@stdlib/assert/is-configurable-propertylib/node_modules/@stdlib/assert/is-data-propertylib/node_modules/@stdlib/assert/is-data-property-inlib/node_modules/@stdlib/assert/is-enumerable-propertylib/node_modules/@stdlib/assert/is-enumerable-property-inlib/node_modules/@stdlib/assert/is-nonconfigurable-propertylib/node_modules/@stdlib/assert/is-nonconfigurable-property-inlib/node_modules/@stdlib/assert/is-nonenumerable-propertylib/node_modules/@stdlib/assert/is-read-only-propertylib/node_modules/@stdlib/assert/is-read-only-property-inlib/node_modules/@stdlib/assert/is-read-write-propertylib/node_modules/@stdlib/assert/is-read-write-property-inlib/node_modules/@stdlib/assert/is-readable-property-inlib/node_modules/@stdlib/assert/is-writable-propertylib/node_modules/@stdlib/assert/is-writable-property-inlib/node_modules/@stdlib/assert/is-write-only-propertylib/node_modules/@stdlib/assert/is-write-only-property-inRelated Issues
None.
Questions
No.
Other
Validation
lib/node_modules/@stdlib/**/test/*.jsandlib/node_modules/@stdlib/**/benchmark/*.js. Originating packages already fixed by the source commits (assert/is-readable-property) were excluded.confirmedfor all 19 P2 sites. A separate Opus adaptation agent generated the per-site P2 patches (import-after-anchor + line replace), and a Sonnet style-consistency agent confirmed each replacement matches the source-commit precedent.41d54f5and6f01b40(originally bundled with this PR) were dropped after reviewer feedback: the empty lines separating fixture import blocks are intentional logical-group separators (e.g.,column_major_*vsrow_major_*), not stray whitespace. See discussion at bench: replacenew Array(100)withzeros(100, 'generic')inassert/is-*-propertybenchmarks #12010 (comment).01ddffb2("docs: propagate recent fixes acrossstats/base/distsandlapack/base") — itself a propagation commit; recent-merge dedup applies.f7b9386("docs: place copy in codeblock") — one-off editorial fix todocs/contributing/zen_of_stdlib.mdwith no replicable search signature.new Array(N)regex but rejected:math/strided/special/*-by,math/strided/ops/*-by,strided/base/*-by, andstats/strided/*-bytest files usenew Array(5)to construct intentionally sparse arrays — replacing withzeros(5, 'generic')would change test semantics (callbacks skip holes but would process zero-valued slots).assert/is-prototype-of/benchmark.jsandassert/is-arraybuffer-view/test/*.js—new Array(N)used as a value in a heterogeneous-type-dispatch literal; replacement would change the runtime type observed by the type-checking function.stats/{fligner,bartlett,kruskal}-test,stats/{ttest2,vartest,binomial-test,chi2gof},blas/base/gasum,array/pool, and severalutils/*benchmark files — arrays fully overwritten in a fill loop before any read; theArrayconstructor here triggers the lint rule but the values are not semantically uninitialized.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a routine that scans recent
developcommits for generalizable fixes and propagates them to sibling packages. Each propagation site was independently verified by two Opus validation agents, an Opus adaptation agent (for thenew Array→zerossubstitution), and a Sonnet style-consistency agent before patches were applied. The changes are mechanical analogs of the cited source commits and touch only benchmark setup.Generated by Claude Code