refactor: align blas/ext/base/gcartesian-square JSDoc and accessor return with siblings#11988
Merged
Merged
Conversation
…urn with siblings Annotate `N` as a `PositiveInteger` to match every sibling strided routine (`gfill`, `gcusum`, `dwhere`, `swhere`, `gcartesian-power`), and align the accessor branch with `gcartesian-power/lib/accessors.js` by returning the original `out` collection (not the underlying buffer) and updating the `@returns` annotation accordingly.
stdlib-bot
added
the
BLAS
Contributor
Coverage ReportNo coverage information available. |
…/base/gcartesian-square`
The implementation handles `N = 0` via the `if ( N <= 0 ) { return out; }` guard
in `ndarray.js`, and the cartesian-family siblings (`gcartesian-power`,
`dcartesian-square`, `scartesian-square`) all annotate `N` as `NonNegativeInteger`.
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Planeshifter
changed the title
blas/ext/base/gcartesian-square JSDoc and accessor return with siblingsblas/ext/base/gcartesian-square JSDoc and accessor return with siblings
kgryte
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-05-06 14:57 -0400 and 2026-05-06 18:39 -0700 (SHA range26286631e…5293ab638, 22 first-parent commits).Description
This pull request:
blas/ext/base/gcartesian-squarewith sibling strided routines inblas/ext/base.blas/ext/base/gcartesian-square0c3e5bd9eforblas/ext/base/gcartesian-square:accessors.jsnow returnsout(not the underlying bufferobuf) with a corrected@returns {Object} output array objectannotation, andndarray.jsinvokesaccessors(...)for its side effect and returnsoutdirectly, aligning behavior and docs with the siblinggcartesian-powerpackage.{NonNegativeInteger}annotation on parameterNinblas/ext/base/gcartesian-square(introduced in0c3e5bd9e), aligning with the{PositiveInteger}convention used across all sibling strided routines inblas/ext/base.Related Issues
None.
Questions
No.
Other
Generated by an automated review of the 22 first-parent commits merged to
developin the preceding 24-hour window.Validation performed:
docs/style-guides/javascript,docs/style-guides/c).gcartesian-power,gfill,gcusum,dwhere,swhere,zwhere.Deliberately excluded:
to-reversed-dimensionsJSDoc-vs-error-message wording, where downstreamreverseDimensionsenforces the broader contract).gcartesian-squareREADME, which is consistent with every other cartesian-family sibling (gcartesian-power,dcartesian-power,scartesian-power,dcartesian-square,scartesian-square).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as a follow-up review of commits merged to
developin the preceding 24 hours. Findings were validated against established sibling packages, and only high-signal issues with concrete, in-scope fixes were applied.Generated by Claude Code