feat(communities): publish community control on the default shard (32) (#7498 phase 2) - #7540
Draft
igor-sirotin wants to merge 1 commit into
Draft
feat(communities): publish community control on the default shard (32) (#7498 phase 2)#7540igor-sirotin wants to merge 1 commit into
igor-sirotin wants to merge 1 commit into
Conversation
|
Member
Jenkins BuildsClick to see older builds (15)
|
igor-sirotin
force-pushed
the
feat/publish-community-control-shard-32
branch
from
June 9, 2026 20:58
b50c6c5 to
7acfb95
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7540 +/- ##
===========================================
- Coverage 61.78% 61.76% -0.03%
===========================================
Files 849 849
Lines 118727 118727
===========================================
- Hits 73360 73331 -29
- Misses 37882 37912 +30
+ Partials 7485 7484 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Phase 2 of the single-shard migration (#7498). Stacked on the phase-1 listen change (#7538). Switch the five community-control send sites (request/cancel to join, request-to-join response, user kicked, shared-addresses response) from the non-protected shard (64) to the default shard (32). Listening is unchanged: still both 32 and 64 (phase 1). So a phase-1 peer, which already listens on 32, receives these, and this client still receives a peer's shard-64 traffic — N±1 interop-safe. The DefaultFilters listen entries are untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
igor-sirotin
force-pushed
the
feat/publish-community-control-shard-32
branch
from
June 17, 2026 08:33
7acfb95 to
c257add
Compare
Collaborator
Author
|
Results against v10.32 and v10.33. Now pushed a v10.34.0 tag, testing with it. 
|
Collaborator
Author
|
Looks pretty much as expected with v10.34.0. Will now skip these 2 tests for 
|
igor-sirotin
marked this pull request as draft
July 22, 2026 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Phase 2 of the single-shard migration (#7498), part of the logos-delivery
Messaging API integration (logos-messaging/pm#380).
Stacked on #7538 (phase 1 — listen on shard 32 in addition to 64). Please
review/merge that first; this PR's diff is only the send-side delta.
Switch the five community-control send sites in
protocol/messenger_communities.gofromDefaultNonProtectedPubsubTopic()(shard64) to
DefaultShardPubsubTopic()(shard 32):COMMUNITY_REQUEST_TO_JOIN)COMMUNITY_CANCEL_REQUEST_TO_JOIN)COMMUNITY_REQUEST_TO_JOIN_RESPONSE)COMMUNITY_USER_KICKED)COMMUNITY_SHARED_ADDRESSES_RESPONSE)Converging community messaging onto the default shard (32) and dropping shard 64
is a prerequisite for the content-topic-only auto-sharding of the Messaging API.
Interop (N±1)
Listening is unchanged — still both 32 and 64 (phase 1). So a phase-1 peer, which
already listens on 32, receives our shard-32 sends; and we still receive a peer's
shard-64 sends. The 64 listen filter is dropped in phase 3 (#7505).
Notes
feat/community-control-send-shard-32(feat(communities): listen for community control on the default shard (32) (#7498 phase 1) #7538). Will retarget todeveloponce feat(communities): listen for community control on the default shard (32) (#7498 phase 1) #7538 merges.🤖 Generated with Claude Code