Skip to content

fix(metrics): escape decimal point in final_number_exact_match regex #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devteamaegis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(metrics): escape decimal point in final_number_exact_match regex #4317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/helm/benchmark/metrics/evaluate_reference_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def final_number_exact_match(gold: str, pred: str) -> float:
"""

def get_final_number(x: str) -> str:
matches = re.findall(r"-?[\d,]+(?:.\d+)?", x)
matches = re.findall(r"-?[\d,]+(?:\.\d+)?", x)
if not matches:
return ""
return matches[-1].replace(",", "")
Expand Down
3 changes: 3 additions & 0 deletions src/helm/benchmark/metrics/test_evaluate_reference_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ def test_final_number_exact_match():
assert final_number_exact_match("34.2", "2") == 0
assert final_number_exact_match("342", "342.") == 1
assert final_number_exact_match("3,420", "3420") == 1
# A non-digit, non-dot character between digits must not be treated as part of a number.
assert final_number_exact_match("30", "the meeting is at 7:30") == 1
assert final_number_exact_match("3", "the grid is 2x3") == 1


def test_bleu_1():
Expand Down