Skip to content

fix(http): return early on request errors to prevent nil pointer panic #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AruneshDwivedi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(http): return early on request errors to prevent nil pointer panic #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/http/httpClient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ func (client *HttpClient) RequestWithHeaders(requestType string, body []byte, he
log.Error(err, "Failed to craft HTTP Request. METHOD: "+requestType+
" URL: "+client.url+
" PAYLOAD: "+string(body))
return HttpResponse{
StatusCode: http.StatusInternalServerError,
Header: make(http.Header),
}
}

if headers != nil {
Expand All @@ -50,8 +54,16 @@ func (client *HttpClient) RequestWithHeaders(requestType string, body []byte, he
response, err := http.DefaultClient.Do(request)
if err != nil {
log.Error(err, "")
return HttpResponse{
StatusCode: http.StatusInternalServerError,
Header: make(http.Header),
}
} else if response == nil {
log.Error(nil, "got empty response")
return HttpResponse{
StatusCode: http.StatusInternalServerError,
Header: make(http.Header),
}
}

httpResponse := HttpResponse{
Expand Down
Loading