global cache not used when watchNamespaces is empty in the helm values - #663
Merged
Merged
Conversation
Signed-off-by: Mahagon <874007+Mahagon@users.noreply.github.com>
Signed-off-by: Mahagon <874007+Mahagon@users.noreply.github.com>
…ing guide Signed-off-by: Mahagon <874007+Mahagon@users.noreply.github.com>
Signed-off-by: Mahagon <874007+Mahagon@users.noreply.github.com>
SyedaFatimaKazmi
added
ok-to-test
SyedaFatimaKazmi
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
watchNamespacesis set to an empty string, the controller fails to list pods in specific namespaces with:DefaultNamespaceswas always populated, including with{"": {}}whenWATCH_NAMESPACEwas empty.Added Unit tests for it (hope the path is fine for you)
Also fixed a path in the
CONTRIBUTING.mdwhile i was on it.btw the last version push failed:
https://github.com/stakater/IngressMonitorController/actions/runs/23251348418/job/67688512380#step:12:45
It seems the uptimerobot test fails, can't really test it as i just got Statuscake.