feat: model experiments wait handler#7800
Open
paul-sffrth wants to merge 5 commits into
Open
Conversation
GokceGK
reviewed
Jun 17, 2026
| ) | ||
|
|
||
| // CreateMExpInstanceWaitHandler will wait for creation of Model Experiments instance | ||
| func CreateMExpInstanceWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceResponse] { |
Contributor
There was a problem hiding this comment.
Suggested change
| func CreateMExpInstanceWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceResponse] { | |
| func CreateModelExperimentsInstanceWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceResponse] { |
GokceGK
reviewed
Jun 17, 2026
| ActiveState: []modelexperiments.InstanceState{modelexperiments.INSTANCESTATE_ACTIVE}, | ||
| ErrorState: []modelexperiments.InstanceState{modelexperiments.INSTANCESTATE_IMPAIRED}, | ||
| } | ||
| handler := wait.New(waitConfig.Wait()) |
Contributor
There was a problem hiding this comment.
Suggested change
| handler := wait.New(waitConfig.Wait()) | |
| handler := wait.New(waitConfig.Wait()) | |
| handler.SetTimeout(10 * time.Minute) | |
| return handler |
GokceGK
reviewed
Jun 17, 2026
| } | ||
|
|
||
| // DeleteMExpInstanceWaitHandler will wait for deletion of Model Experiments instance | ||
| func DeleteMExpInstanceWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceResponse] { |
Contributor
There was a problem hiding this comment.
Suggested change
| func DeleteMExpInstanceWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceResponse] { | |
| func DeleteModelExperimentsInstanceWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceResponse] { |
GokceGK
reviewed
Jun 17, 2026
| }, | ||
| DeleteHttpErrorStatusCodes: []int{http.StatusNotFound}, | ||
| } | ||
| handler := wait.New(waitConfig.Wait()) |
Contributor
There was a problem hiding this comment.
Like mentioned in create function, please group handler and following lines together.
GokceGK
reviewed
Jun 17, 2026
| } | ||
|
|
||
| // CreateMExpTokenWait Handler will wait for creation of Model Experiments instance token | ||
| func CreateMExpInstanceTokenWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId, tokenId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceTokenResponse] { |
Contributor
There was a problem hiding this comment.
Suggested change
| func CreateMExpInstanceTokenWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId, tokenId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceTokenResponse] { | |
| func CreateModelExperimentsInstanceTokenWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId, tokenId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceTokenResponse] { |
GokceGK
reviewed
Jun 17, 2026
| ActiveState: []modelexperiments.TokenState{modelexperiments.TOKENSTATE_ACTIVE}, | ||
| ErrorState: []modelexperiments.TokenState{}, | ||
| } | ||
| handler := wait.New(waitConfig.Wait()) |
GokceGK
reviewed
Jun 17, 2026
| } | ||
|
|
||
| // DeleteMExpInstanceTokenWaitHandler will wait for deletion of Model Experiments instance token | ||
| func DeleteMExpInstanceTokenWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId, tokenId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceTokenResponse] { |
Contributor
There was a problem hiding this comment.
Suggested change
| func DeleteMExpInstanceTokenWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId, tokenId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceTokenResponse] { | |
| func DeleteModelExperimentsInstanceTokenWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId, tokenId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceTokenResponse] { |
GokceGK
reviewed
Jun 17, 2026
| }, | ||
| DeleteHttpErrorStatusCodes: []int{http.StatusNotFound}, | ||
| } | ||
| handler := wait.New(waitConfig.Wait()) |
GokceGK
reviewed
Jun 17, 2026
| } | ||
| } | ||
|
|
||
| func TestCreateMExpInstanceWaitHandler(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Please adapt test names also
GokceGK
reviewed
Jun 17, 2026
|
|
||
| modelexperimentsClient, err := modelexperiments.NewAPIClient() | ||
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "Creating API client: %v\n", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Fprintf(os.Stderr, "Creating API client: %v\n", err) | |
| fmt.Fprintf(os.Stderr, "[Model Experiments] Creating API client: %v\n", err) |
GokceGK
reviewed
Jun 17, 2026
| os.Exit(1) | ||
| } | ||
|
|
||
| // Create a instance |
Contributor
There was a problem hiding this comment.
Suggested change
| // Create a instance | |
| // Create an instance |
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
| createTokenPayload := modelexperiments.CreateInstanceTokenPayload{ | ||
| Name: "token-name", | ||
| } | ||
| createTokenResp, err := modelexperimentsClient.DefaultAPI.CreateInstanceToken(context.Background(), projectId, region, createInstanceResp.Instance.Id).CreateInstanceTokenPayload(createTokenPayload).Execute() |
Contributor
There was a problem hiding this comment.
Wait handler is missing also in here.
GokceGK
reviewed
Jun 17, 2026
Contributor
|
Thanks for your contribution. Notice.txt is not part of this PR, but I just recognized a point in there. Can you please change the first line to STACKIT Model Experiments SDK for Go |
GokceGK
reviewed
Jun 17, 2026
GokceGK
reviewed
Jun 17, 2026
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "Error when calling `GetInstance`: %v\n", err) | ||
| } else { | ||
| fmt.Printf("Retrieved instance: %+v\n", getInstanceResp.Instance) |
Contributor
There was a problem hiding this comment.
maybe instead of printing whole instance, you can print 1-2 fields like name and description to increase output readability. As some printed fields are just nil or addresses.
GokceGK
reviewed
Jun 17, 2026
| os.Exit(1) | ||
| } | ||
|
|
||
| // Create an Model Experiments Instance |
Contributor
There was a problem hiding this comment.
Suggested change
| // Create an Model Experiments Instance | |
| // Create a Model Experiments Instance |
GokceGK
reviewed
Jun 17, 2026
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "[Model Experiments] Error when calling `CreateInstance`: %v\n", err) | ||
| } else { | ||
| fmt.Printf("[Model Experiments] Created Model Experiments Instance with ID: \"%s\".\n", createInstanceResp.Instance.Id) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Printf("[Model Experiments] Created Model Experiments Instance with ID: \"%s\".\n", createInstanceResp.Instance.Id) | |
| fmt.Printf("[Model Experiments] Triggered creation of Model Experiments Instance with ID: \"%s\".\n", createInstanceResp.Instance.Id) |
GokceGK
reviewed
Jun 17, 2026
| } | ||
| createInstanceResp, err := modelexperimentsClient.DefaultAPI.CreateInstance(ctx, projectId, region).CreateInstancePayload(createInstancePayload).Execute() | ||
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "[Model Experiments] Error when calling `CreateInstance`: %v\n", err) |
Contributor
There was a problem hiding this comment.
You should either use log.Fatalf instead of fmt.Fprintf or use os.Exit(1) wherever you get an error.
This comment is valid also for the rest of the file.
GokceGK
reviewed
Jun 17, 2026
| fmt.Printf("[Model Experiments] Retrieved %d instances\n", len(listInstaceResp.Instances)) | ||
| } | ||
|
|
||
| // Update an Model Experiments Instance |
Contributor
There was a problem hiding this comment.
Suggested change
| // Update an Model Experiments Instance | |
| // Update a Model Experiments Instance |
GokceGK
reviewed
Jun 17, 2026
| } | ||
|
|
||
| // List Model Experiments Instances | ||
| listInstaceResp, err := modelexperimentsClient.DefaultAPI.ListInstances(ctx, projectId, region).Execute() |
Contributor
There was a problem hiding this comment.
Suggested change
| listInstaceResp, err := modelexperimentsClient.DefaultAPI.ListInstances(ctx, projectId, region).Execute() | |
| listInstanceResp, err := modelexperimentsClient.DefaultAPI.ListInstances(ctx, projectId, region).Execute() |
GokceGK
reviewed
Jun 17, 2026
| fmt.Printf("[Model Experiments] Retrieved Model Experiments Instance with ID: \"%s\" and display name: \"%s\"\n", getInstanceResp.Instance.Id, getInstanceResp.Instance.Name) | ||
| } | ||
|
|
||
| // List Model Experiments Instances |
Contributor
There was a problem hiding this comment.
fmt.Printf("[Model Experiments] Listing Model Experiments instances.\n")
GokceGK
reviewed
Jun 17, 2026
| fmt.Printf("[Model Experiments] Retrieved %d instances\n", len(listInstaceResp.Instances)) | ||
| } | ||
|
|
||
| // Update an Model Experiments Instance |
Contributor
There was a problem hiding this comment.
fmt.Printf("[Model Experiments] Updating Model Experiments Instance.\n")
GokceGK
reviewed
Jun 17, 2026
| fmt.Printf("[Model Experiments] Updated Model Experiments Instance with ID: \"%s\" and display name: \"%s\"\n", partialUpdateInstanceResp.Instance.Id, partialUpdateInstanceResp.Instance.Name) | ||
| } | ||
|
|
||
| // Delete an Model Experiments Instance |
Contributor
There was a problem hiding this comment.
Suggested change
| // Delete an Model Experiments Instance | |
| // Delete a Model Experiments Instance |
GokceGK
reviewed
Jun 17, 2026
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "[Model Experiments] Error when calling `DeleteInstance`: %v\n", err) | ||
| } else { | ||
| fmt.Printf("[Model Experiments] Deleted Model Experiments Instance with ID: \"%s\" and display name: \"%s\"\n", deleteInstanceResp.Instance.Id, deleteInstanceResp.Instance.Name) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Printf("[Model Experiments] Deleted Model Experiments Instance with ID: \"%s\" and display name: \"%s\"\n", deleteInstanceResp.Instance.Id, deleteInstanceResp.Instance.Name) | |
| fmt.Printf("[Model Experiments] Triggered deletion of Model Experiments Instance with ID: \"%s\" and display name: \"%s\"\n", deleteInstanceResp.Instance.Id, deleteInstanceResp.Instance.Name) |
GokceGK
reviewed
Jun 17, 2026
| fmt.Printf("[Model Experiments] Updated Model Experiments Instance with ID: \"%s\" and display name: \"%s\"\n", partialUpdateInstanceResp.Instance.Id, partialUpdateInstanceResp.Instance.Name) | ||
| } | ||
|
|
||
| // Delete an Model Experiments Instance |
Contributor
There was a problem hiding this comment.
You should delete the instance at the end of the script, after you delete the token.
Otherwise, this will cause error.
[Model Experiments] Error when calling `CreateToken`: 404 Not Found, status code 404, Body: {"code":404,"message":"mlflow service not available: instance not found","status":"Not Found"}
panic: runtime error: invalid memory address or nil pointer dereference
GokceGK
reviewed
Jun 17, 2026
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "[Model Experiments] Error when calling `CreateToken`: %v\n", err) | ||
| } else { | ||
| fmt.Printf("[Model Experiments] Created Model Experiments Instance Token: %+v\n", createTokenResp.Token) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Printf("[Model Experiments] Created Model Experiments Instance Token: %+v\n", createTokenResp.Token) | |
| fmt.Printf("[Model Experiments] Triggered creation of Model Experiments Instance Token: %+v\n", createTokenResp.Token) |
GokceGK
reviewed
Jun 17, 2026
| } | ||
| fmt.Printf("[Model Experiments] Model Experiments Instance \"%s\" has been successfully deleted.\n", deleteInstanceResp.Instance.Id) | ||
|
|
||
| // Create an Model Experiments Instance Token |
Contributor
There was a problem hiding this comment.
Suggested change
| // Create an Model Experiments Instance Token | |
| // Create a Model Experiments Instance Token |
GokceGK
reviewed
Jun 17, 2026
| fmt.Printf("[Model Experiments] Retrieved %d instance tokens\n", len(listTokenResp.Tokens)) | ||
| } | ||
|
|
||
| // Update an Model Experiments Instance Token |
Contributor
There was a problem hiding this comment.
Suggested change
| // Update an Model Experiments Instance Token | |
| // Update a Model Experiments Instance Token |
GokceGK
reviewed
Jun 17, 2026
| fmt.Printf("[Model Experiments] Updated Model Experiments Instance Token with ID: \"%s\" and display name: \"%s\"\n", partialUpdateTokenResp.Token.Id, partialUpdateTokenResp.Token.Name) | ||
| } | ||
|
|
||
| // Delete an Model Experiments Instance Token |
Contributor
There was a problem hiding this comment.
Suggested change
| // Delete an Model Experiments Instance Token | |
| // Delete a Model Experiments Instance Token |
GokceGK
reviewed
Jun 17, 2026
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "[Model Experiments] Error when calling `DeleteInstanceToken`: %v\n", err) | ||
| } else { | ||
| fmt.Printf("[Model Experiments] Deleted Model Experiments Instance Token with ID: \"%s\" and display name: \"%s\"\n", deleteTokenResp.Token.Id, deleteTokenResp.Token.Name) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Printf("[Model Experiments] Deleted Model Experiments Instance Token with ID: \"%s\" and display name: \"%s\"\n", deleteTokenResp.Token.Id, deleteTokenResp.Token.Name) | |
| fmt.Printf("[Model Experiments] Triggered deletion of Model Experiments Instance Token with ID: \"%s\" and display name: \"%s\"\n", deleteTokenResp.Token.Id, deleteTokenResp.Token.Name) |
GokceGK
reviewed
Jun 17, 2026
| ) | ||
|
|
||
| // CreateModelExperimentsInstanceWaitHandler will wait for creation of Model Experiments instance | ||
| func CreateModelExperimentsInstanceWaitHandler(ctx context.Context, a modelexperiments.DefaultAPI, region, projectId, instanceId string) *wait.AsyncActionHandler[modelexperiments.GetInstanceResponse] { |
Contributor
There was a problem hiding this comment.
I am thinking if it is better to remove the ModelExperiments completely from the function name.
CreateInstanceWaitHandler
DeleteInstanceWaitHandler
CreateInstanceTokenWaitHandler
DeleteInstanceTokenWaitHandler
Contributor
There was a problem hiding this comment.
@marceljk what do you think? Is it better without service name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wait handlers for model experiments
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)