Skip to content

fix: pr-bug-scan validated finding from #8690 #8759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buf0-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

fix: pr-bug-scan validated finding from #8690 #8759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions mobile/app/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,10 +528,15 @@ export default function HomeScreen() {
fetchTaskProviders(entry.client, entry.hostId, setTaskProvidersByHost, () => false)
}
} else {
if (unsubNotif) {
unsubNotif()
unsubNotif = null
}
// Why (#8129): keep the notification subscription alive across the
// reconnect cycle. subscribeToDesktopNotifications relies on the RPC
// client replaying its stream and re-emitting `ready` on reconnect to
// trigger catch-up (fetchMissed, gated on reconnectReadyCount > 1).
// Tearing it down on every non-'connected' state destroyed and
// recreated the subscription each reconnect, resetting the internal
// reconnectReadyCount to 0 so catch-up never fired. The subscription
// is still disposed by the effect cleanup below when the
// (hostId, client) pair changes.
if (unsubAccounts) {
unsubAccounts()
unsubAccounts = null
Expand Down
Loading