Use SemVer as the single versioning scheme#956
Merged
Conversation
albertospelta
force-pushed
the
feature/issue-874-single-semver
branch
from
fcdbbc1 to
6ae6b20
Compare
Replace the two divergent version numbers (3-part product version vs. date-based 4-part file version) with one controlled SemVer declared in version.json and computed by NBGV. FileVersion becomes Major.Minor.Patch.{gitHeight}, so the Patch is now part of the file version used for update comparison, and ApplicationProductVersion is the cleanMajor.Minor.Patch shown to users.
albertospelta
force-pushed
the
feature/issue-874-single-semver
branch
from
6ae6b20 to
bfa3cf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the two divergent version numbers (3-part product version vs. date-based 4-part file version) with one controlled SemVer declared in version.json and computed by NBGV. AppVersionInfo.Version (clean Major.Minor.Patch) is the single version used everywhere user-facing and for update-check comparisons; AppVersionInfo.Build (Major.Minor.Patch.{gitHeight}) is kept only for diagnostics (telemetry) and is never compared or shown to users.