Skip to content

PR: Do not discard completions that contain textEdit #10637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andfoy wants to merge 1 commit into from
Closed

PR: Do not discard completions that contain textEdit #10637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions spyder/plugins/editor/widgets/codeeditor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,9 +1069,17 @@ def process_completion(self, params):
position, automatic = args
try:
completions = params['params']
completions = ([] if completions is None else
[completion for completion in completions
if completion['insertText']])
if completions is None:
completions = []
else:
actual_completions = []
for completion in completions:
insert_text_valid = ('insertText' in completion and
completion['insertText'])
text_edit_valid = 'textEdit' in completion
if insert_text_valid or text_edit_valid:
actual_completions.append(completion)
completions = actual_completions

replace_end = self.textCursor().position()
under_cursor = self.get_current_word_and_position(completion=True)
Expand Down